Quality.title generating wrong info

rhom · May 6, 2018, 1:29pm

i have an episode (several actually) that i converted (im archiving them) to x265 leaving the aspect ratio as-is. the converted ep had a filename of show.s01e01.mkv

sonarr is set to analyse video

i deleted the original file, then rescanned the show, then renamed

the converted file has a resolution of 720x416 (720x404) yet when sonarr renamed it, it came back as show.s01e01.hdtv-720p.x265.aac.mkv

720p is supposed to be 720 lines high, not pixels wide, isnt it? this ep should be sdtv-480p

is there some other media properties its looking at to get 720p from? or something i’m missing?

Docker container from linuxerver/sonarr:latest
Version 2.0.0.5163
Mono Version 5.10.1.20
Synology DSM 6.1.6

standard episode format is set to {series.cleantitle}.s{season:00}e{episode:00}.{quality.title}.{mediainfo.simple}

Mirx_NL · May 6, 2018, 6:29pm

Not the answer to your question. but why don’t you just insert a quality tag in the filename when converting them?

As for your question, I would start by checking what mediainfo reports when process the file without Sonarr.
Then I would turn on debug logging and check what mediainfo is parsing.

As for the rules, they are pretty straight forward.

github.com

Sonarr/Sonarr/blob/81e385bebfc33c949fbb8f2dbbbd94ac445fcf5c/src/NzbDrone.Core/MediaFiles/EpisodeImport/Aggregation/Aggregators/Augmenters/Quality/AugmentQualityFromMediaInfo.cs

using NzbDrone.Core.Parser.Model;

namespace NzbDrone.Core.MediaFiles.EpisodeImport.Aggregation.Aggregators.Augmenters.Quality
{
    public class AugmentQualityFromMediaInfo : IAugmentQuality
    {
        public AugmentQualityResult AugmentQuality(LocalEpisode localEpisode)
        {
            if (localEpisode.MediaInfo == null)
            {
                return null;
            }

            var width = localEpisode.MediaInfo.Width;

            if (width >= 3200)
            {
                return AugmentQualityResult.ResolutionOnly(2160, Confidence.MediaInfo);
            }

This file has been truncated. show original

rhom · May 7, 2018, 1:50am

am i reading that correctly? the code is checking the resolution width, not its height?

isnt quality (480/720/1080) based on the resolution height?

Mirx_NL · May 7, 2018, 5:52am

If you run mediainfo manually you’ll see:

Width : 1 920 pixels
Height : 1 080 pixels

github.com

Sonarr/Sonarr/blob/81e385bebfc33c949fbb8f2dbbbd94ac445fcf5c/src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Aggregation/Aggregators/Augmenters/Quality/AugmentQualityFromMediaInfoFixture.cs

using FizzWare.NBuilder;
using FluentAssertions;
using NUnit.Framework;
using NzbDrone.Core.MediaFiles.EpisodeImport.Aggregation.Aggregators.Augmenters.Quality;
using NzbDrone.Core.MediaFiles.MediaInfo;
using NzbDrone.Core.Parser.Model;
using NzbDrone.Core.Test.Framework;

namespace NzbDrone.Core.Test.MediaFiles.EpisodeImport.Aggregation.Aggregators.Augmenters.Quality
{
    [TestFixture]
    public class AugmentQualityFromMediaInfoFixture : CoreTest<AugmentQualityFromMediaInfo>
    {
        [Test]
        public void should_return_null_if_media_info_is_null()
        {
            var localEpisode = Builder<LocalEpisode>.CreateNew()
                                                    .With(l => l.MediaInfo = null)
                                                    .Build();

This file has been truncated. show original

has some examples.

If have no idea why they opted to code it this way, probably to account for cropping. As it is opensource, you’re always welcome to open an issue or post a commit.

But does it really matter? In your case your width is 720, which is less then 1200, and should report back as SD like you want.

So back to square 1 and check what mediainfo is reporting.

rhom · May 7, 2018, 9:00am

those resolutions in my first post are from mediainfo (and VLC)

neither 720x416 or 720x404 are HD

the examples from the code with a comparable resolution shows them as SD

yes, its matters. it should come back as SD, but it doesnt

sonarr keeps applying hdtv-720p to the files

Mirx_NL · May 7, 2018, 9:26am

What I meant was it doesn’t matter if it is using width or height, your file should match SD. I was just pointing out there was no point in looking further into the matching criteria, as in your case it should have the same result.

Guess the only thing is enable debug logging and see the actual Sonarr behaviour in the logfile.

system · July 6, 2018, 9:30am

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.