DoNotDownload doesn't pause or stop torrents in rTorrent / ruTorrent

DominicM · August 26, 2018, 1:12pm

Version 2.0.0.5228
Mono Version 4.8.1
OS Fedora 28

I have DoNotDownload selected for both recent and older releases but the torrents are added to rTorrent and start downloading automatically. I am using ruTorrent via “rtorrent/plugins/rpc/rpc.php” url. Torrents get added as paused when added via chrome add-on so ruTorrent is working properly. The same issue is present in latest develop branch of Radarr. Is this a bug or am I missing something about this feature?

markus101 · August 27, 2018, 5:49pm

Do not download will use the command d.priority.set=0 when the torrent is added, perhaps something different is required, but I don’t know.

DominicM · August 27, 2018, 7:20pm

according to rtorrent doc it does seem like d.priority.set=o should set it to off state.

The only difference between the chrome plugin and sonarr is that the plugin only needs a path to rutorrent instead of to the rpc plugin within rutorrent path. Not sure if that could cause issues.

I couldn’t find the exact command used by the plugin, maybe someone else can find it in the source code: https://github.com/bogenpirat/remote-torrent-adder

Actually it seems the relevant lines in the plugin source code are these:

if(server.rutorrentaddpaused)
		url += "&torrents_start_stopped=1";

It’s building a url to in my case to “/usr/share/webapps/rutorrent/php/addtorrent.php”

markus101 · August 27, 2018, 10:13pm

Which eventually leads rutorrent to use a different command when queuing the torrent

github.com

Novik/ruTorrent/blob/44d43229f07212f20b53b6301fb25882125876c3/php/rtorrent.php#L34


				}			
			if($isNew)
			{
				if(isset($torrent->{'rtorrent'}))
					unset($torrent->{'rtorrent'});
			}
			$raw_value = base64_encode($torrent->__toString());
			$filename = is_object($fname) ? $torrent->getFileName() : $fname;
			if((strlen($raw_value)<self::RTORRENT_PACKET_LIMIT) || is_null($filename) || !isLocalMode())
			{
				$cmd = new rXMLRPCCommand( $isStart ? 'load_raw_start' : 'load_raw' );
				$cmd->addParameter($raw_value,"base64");
				if(!is_null($filename) && !$saveTorrent)
					@unlink($filename);
			}
			else
			{
				$cmd = new rXMLRPCCommand( $isStart ? 'load_start' : 'load' );
				$cmd->addParameter($filename);
			}
			if(!is_null($filename) && (rTorrentSettings::get()->iVersion>=0x805))

or

github.com

Novik/ruTorrent/blob/44d43229f07212f20b53b6301fb25882125876c3/php/rtorrent.php#L98


	        	$hpos+=12;
	        	$fpos = stripos($magnet,'&',$hpos);
			if($fpos===false)
				$fpos = strlen($magnet);
			$hash = strtoupper(substr($magnet,$hpos,$fpos-$hpos));
if(strlen($hash)==32)
		        	$hash = base32decode($hash);
	        	if(strlen($hash)==40)
	        	{
				$req = new rXMLRPCRequest();
				$cmd = new rXMLRPCCommand( $isStart ? 'load_start' : 'load' );
				$cmd->addParameter($magnet);
				$directory = self::parseDirectory($directory, $isAddPath);
				if($directory && (strlen($directory)>0))
				{
					if(!rTorrentSettings::get()->correctDirectory($directory))
						return(false);
					$cmd->addParameter( ($isAddPath ? getCmd("d.set_directory=")."\"" : getCmd("d.set_directory_base=")."\"").$directory."\"" );
					$req->addCommand( new rXMLRPCCommand( 'execute', array('mkdir','-p',$directory) ) );
				}
				if($label && (strlen($label)>0))

Depending if it’s a torrent file or a magnet.

A completely different approach than Sonarr utilizes.

Either a priority of 0 doesn’t disable download priority or it’s not being applied properly, does setting it to High set it properly when Sonarr queues a torrent?

DominicM · August 28, 2018, 8:43am

I tried manually snatching a release and yes it does set the priority to high or low depending on the setting.

Actually even DoNotDownload priority is getting set. The problem seem to be that setting priority cannot pause or stop the download. DoNotDownload is just a really bad name for what seems to be the lowest priority, it still downloads just fine after all. I do hope that an add paused checkbox or something like it could be added without much trouble.

markus101 · August 28, 2018, 4:59pm

Yeah, I’ll rename DoNotDownload to VeryLow and add an Add Paused checkbox (same as other clients). It’ll be in a future release.

DominicM · August 28, 2018, 6:24pm

That sounds great, will have to switch to develop branch then! btw, there is also stopped state though I don’t really see much of a difference.

markus101 · August 28, 2018, 9:50pm

Yeah, looks like that’ll be stopped not paused, which is fine. Downside is magnet’s don’t download at all, not sure how that’ll work since it’s HASH.meta instead of a release name.

DominicM · September 3, 2018, 5:12pm

@markus101 One thing I noticed about the add paused feature is that it does not differentiate between recent and older releases like the priority does. Could a second add pause option for recent downloads be added? This would be great since I am quite particular what releases I actually download but don’t want to delay recent downloads.

markus101 · September 3, 2018, 6:17pm

Add Paused is the same as other clients, it’s a global setting for all downloads to that client, no plans to split that out for other clients or rtorrent.

system · November 2, 2018, 6:17pm

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.