As a user when I manually import files I want file versions to survive the process so they don't get deleted

ldexterldesign · July 2, 2019, 5:23pm

Sonarr version (exact version): 2.0.0.5322
Mono version (if Sonarr is not running on Windows): 5.20.1.19
OS: macOS
Debug logs: n/a
Description of issue:

Hi all,

Hope you’re well

Thanks for wonderful software

As a user when I manually import files I want file versions to survive the process so they don’t get deleted

To elaborate, when I manually import I will often cleanup file names so Sonarr will ID correctly. I often download many versions of the same episode so I’ll tag some UID on to the end to differentiate them:

Gardeners' World - 52x16 - Episode 16 - msd
Gardeners' World - 52x16 - Episode 16 - plutonium
Gardeners' World - 52x16 - Episode 16 - soil

Current (export) behaviour

Gardeners' World - s52e16 - Episode 16 - 2019-06-28 - WEBDL-480p - h264 AAC - Sonarr

Two of the highest quality file versions are deleted (if they’re recoverable then please let me know!), meta is added and UID not respected

Expected (export) behaviour

Gardeners' World - s52e16 - Episode 16 - 2019-06-28 - WEBDL-720p - h264 AAC - msd
Gardeners' World - s52e16 - Episode 16 - 2019-06-28 - WEBDL-1080p - h264 AAC - plutonium
Gardeners' World - s52e16 - Episode 16 - 2019-06-28 - WEBDL-480p - h264 AAC - soil

All file versions survive, meta is added and UID respected

At a minimum, how can I prevent losing files during manual import

If you have any issues (e.g. questions/queries) then happy to help

Hope to hear back

Keep up great work!

Yours faithfully

markus101 · July 2, 2019, 5:42pm

Only if you have configured the Recycling Bin in Sonarr.

You can’t import with Sonarr and maintain multiple copies, Sonarr only retains one file. Eventually we’d like to be able to support multiple files for a single episode, but it’s not something we have short term plans for.

ldexterldesign · July 2, 2019, 6:30pm

Thanks for reply

Good to know

Are there recycle bin docs?:

If yes then where
If no then please create something

Lastly, why keep the lowest quality file instead of the highest in a duplicate batch?

Yours hopefully

Simon_Draffin · July 3, 2019, 9:14am

For the Recycle bin, just create a folder where you want deleted files to go, then under setting, media management at the bottom select the folder you created, and save., Any file thats gets deleted will be moved here under show name.

check what profile you have on your shows ie SD , HD-720p HD-1080p. if your show are set for SD anything of higher quality will be ignored

Thirrian · July 3, 2019, 10:16am

Keep in mind that old items in sonarr’s recycle bin folder are removed…

TRaSH · July 9, 2019, 10:36am

They are ?
I don’t think so I got in my Sonarr recycle bin files that have been upgraded or what ever that are more then 3 months old.
Just because I’m too lazy to delete them sometimes

ldexterldesign · July 9, 2019, 11:25am

Cheers all

Doh, I see the recycle bin feature now - must have glanced at that a million times

Lastly, why keep the lowest quality file instead of the highest in a duplicate batch?

Will test this with a fresh OS install shortly and see if the unexpected behaviour still exists

Thanks

Thirrian · July 9, 2019, 12:25pm

I knew I wasn’t dreaming

github.com

Sonarr/Sonarr/blob/phantom-develop/src/NzbDrone.Core/MediaFiles/RecycleBinProvider.cs#L152


    }


    foreach (var file in _diskProvider.GetFiles(_configService.RecycleBin, SearchOption.TopDirectoryOnly))
    {
        _diskProvider.DeleteFile(file);
    }


    _logger.Debug("Recycling Bin has been emptied.");
}


public void Cleanup()
{
    if (string.IsNullOrWhiteSpace(_configService.RecycleBin))
    {
        _logger.Info("Recycle Bin has not been configured, cannot cleanup.");
        return;
    }


    _logger.Info("Removing items older than 7 days from the recycling bin");


    foreach (var folder in _diskProvider.GetDirectories(_configService.RecycleBin))

It does, or at least it should delete anything older than 7 days in that folder…

system · September 7, 2019, 12:25pm

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.