Nzbdrone appears to ignore HTTP 308 redirect

wmassingham · September 5, 2022, 2:01am

While troubleshooting an issue with Whisparr (https://github.com/Whisparr/Whisparr/issues/32), it appears that the HTTP 308 redirect returned by the Whisparr’s API proxy is not properly handled by nzbdrone. It should follow the redirect to https, but it looks like it’s checking the Content-Type header, seeing text/html, and throwing UnexpectedHtmlContentException before following the redirect. I’d expect it to follow the redirects first, then check the Content-Type after the redirects are resolved.

I’ve poked around the source, but I can’t follow the exact sequence of function calls.

bakerboy448 · September 5, 2022, 3:29pm

Whisparr has nothing to do with sonarr…?

markus101 · September 7, 2022, 2:21am

Sonarr replaced NzbDrone years ago.
Are you still running Sonarr v2 (which used nzbdrone for the executables)?

wmassingham · September 14, 2022, 1:17am

No, I’m using current versions. I’m talking about the code in src/NzbDrone.Common/Http.

bakerboy448 · September 14, 2022, 11:53am

Again, Sonarr code has nothing to do with Whisparr…?
Not sure why you believe it does nothing on GitHub indicates it does. The all of the *arrs are completely independent code bases and have no relation to each other.

Just because the code base is similar does not mean they are connected nor related. There is absolutely nothing done in Sonarr’s code that would magically instantly show up in any other *Arr without some human manual intervention

With that said it is an upstream issue in that it can be fixed in Sonarr which then would get pulled downstream to Radarr/Lidarr/Readarr as a new GitHub issue by the bot w/ the commit linked for those to be cherry-picked downstream. GitHub issues for Whisparr and Prowlarr would need to be created manually.

The issue is most likely simply that http 308 is not treated as a redirect which is likely a one or two line fix to add it the list.

But 308 and 307 for that matter are part of the newer RFC https://www.rfc-editor.org/rfc/rfc7238

wmassingham · September 14, 2022, 2:25pm

Yes, Radarr, Whisparr, etc. are all forks of Sonarr and inherit the same code. They’ll need to rebase on Sonarr to pull the commits. That’s why I’m posting this as an upstream issue, so all the projects can benefit.

I’m posting this topic because I wanted to confirm it before opening a github issue. I’m not sure where in the source this behavior would be handled, else I’d just make a pull request.

bakerboy448 · September 14, 2022, 3:15pm

To clarify none of them rebase on any other app. That would be rebase hell given how materially different the apps are

Commits are cherry-picked in

Redirect codes are set here

github.com

Sonarr/Sonarr/blob/dc44cbcda691e776f510bf7eb0da4d4b90b5ba5a/src/NzbDrone.Common/Http/HttpResponse.cs#L53


        {
            _content = Headers.GetEncodingFromContentType().GetString(ResponseData);
        }
        return _content;
    }
}
public bool HasHttpError => (int)StatusCode >= 400;
public bool HasHttpRedirect => StatusCode == HttpStatusCode.Moved ||
                               StatusCode == HttpStatusCode.MovedPermanently ||
                               StatusCode == HttpStatusCode.Found ||
                               StatusCode == HttpStatusCode.TemporaryRedirect ||
                               StatusCode == HttpStatusCode.RedirectMethod ||
                               StatusCode == HttpStatusCode.SeeOther;
public string[] GetCookieHeaders()
{
    return Headers.GetValues("Set-Cookie") ?? new string[0];
}

~~But a 308 should already be handled in Sonarr v4 (GitHub dev branch) and presumably downstream as well as it’s PermanentRedirect~~

Reading post-coffee helps

Typically redirects are followed for requests.

markus101 · September 14, 2022, 5:35pm

The code there doesn’t indicate we handle PermanentRedirect at all.

No need to open a a GHI this is a one line fix…

system · November 13, 2022, 5:35pm

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.