Add 'Add and search for all files not meeting cutoff' button to 'Import Series' page

My situation for example:

I had Sickbeard running and I was deployed without any real access to my server while I was gone. As we know Sickbeard doesn’t attempt new files when there are failures, and a lot of files weren’t up to the cutoff, and some were missing completely from my series. When I came home, I found Sickbeard development rather dead, and made the switch to Sonarr after looking at both Sonarr and Sickrage.

If I do an ‘Add and search for missing,’ many times I’ll have a few missing, with several there, but not at cutoff in my shows. It will then search for the missing episodes as it should.

This method is that, as expected, episodes will be searched for separately. Those episodes will then often be at the cutoff, leaving those that were downloaded but not at cutoff. This leaves them below the quality of the ones that were just searched for when you performed the ‘Add and search for missing’ from Import Series. Yes, you can then do automatic season or automatic/manual episode searches to get the rest of the episodes upgraded with single episode torrents/Usenet posts.

The problem with this is that searching for full season packs, (Blu-ray most often seen) are skipped as a possible upgrade solution. I know some people don’t like season packs, but I still find decent completion with my Usenet/Torrent provider setup for season packs and I’m having to do a lot of backfill. This gives one (or more than one) extra opportunities to get all files to the series cutoff (or above if you don’t have your cutoff also at the top of the priority list.) then if you skipped to trying to find single files through Usenet/torrents.

Many trackers remove single episodes after a season is over, and put up a season pack, but even trackers that don’t remove single episodes see seeds on single episodes dwindle anyway as people move to seed the season packs.

In the case of Usenet, sometimes I can find a season pack that will complete, in situations where some of the matching single episode uploads won’t.

Using ‘Add and search for missing’ then sometimes leaves some episodes at lower qualities than what could have actually have been obtained, because in some cases some of the single episode torrents and usenet single episodes are seedless/uncompleteable.

There are two workarounds:

Use ‘Add and search for missing’ and then possibly be forced to manually check all your indexers/trackers for season packs. In the case of torrents, you can choose to download only those episodes that you are still missing at your max chosen quality (or cutoff.) In the case of Usenet, you’re required to download a lot of additional data for episodes in season packs that have already been downloaded in the proper quality.

Or easier; You can simply click ‘Add’ for each series, and then go to the series, and then ‘Search for all episodes in this series.’ This avoids having to manually search for torrent/Usenet season packs during my example condition, but adds a lot of clicking as I’m importing almost 1,000 shows to Sonarr, as compared to having an ‘Add and search for all episodes not at cutoff.’

I chose the second option. I doubt I’ll be the only person in this situation. Surely, as Sickbeard lies dormant, and will eventually break there will be a mass exodus, and many will come to find Sonarr as their new home. Personally I bet you get many converts from Sickrage as well, as they seem to commit and push a lot of buggy code to their user base and with Jackett there isn’t too much Sickrage has feature-wise that Sonarr can’t compete with and I see many pluses with Sonarr that you don’t get with Sickrage.

Simply put, there may be a lot of people in the near-future that could be saved a lot of work with the added ‘Add and search for all not at cutoff’ button to the import series page.

If 2 or more episodes are missing Sonarr attempts a full season search, which should get full season packs back from the indexers (assuming they have properly detected them and they return then), if the cutoff hasn’t been met for all episodes in the season (either missing or just not met), Sonarr would grab a full season pack.

I don’t see us adding add and search for cutoff unmet, but we’ll be adding a way to search for all cutoff unmet episodes on the cutoff unmet page:

/sigh. I saw that, in fact, I’m otoolejp on Git. I thought that referred to a button that would be placed on the wanted page that would search for episodes for all shows that haven’t met cutoff, where as I’m talking about a button that would go on the import series page to go along with the ‘Add’ and ‘Add and Search for missing episodes’ buttons. The behavior of this button would be to search for all missing and all that haven’t met cutoff only for the show you are importing.

The behavior I see (I just tried it on a show I haven’t imported yet) when you choose ‘Add and Search for missing episodes’ button on the import page is that it only searches for missing episodes. It doesn’t do anything with those that haven’t met cutoff but aren’t missing.

For this particular show all 5 seasons aired have been released in Bluray and 720p Bluray is the top listed quality, and also the 1080p Bluray is listed below it, and is the cutoff. Seasons 1, 2, and 4 that cutoff was already met and those seasons weren’t searched for as expected. Season 3 was completely missing, (The HDD that contained it died while I was away.) Season 3 was searched, and it downloaded single 720p Bluray episodes for the whole season (not the issue, as there didn’t happen to be any season packs. I know it would have grabbed one if there was one.)

Season 5 has 1 episode at cutoff or higher (720p Bluray) while all other episodes in the season are present in various qualities not meeting the cutoff. The ‘Add and Search for missing’ season import button never even performed a search for Season 5. This is why I’m requesting the button be added. If a show is being imported for the first time, it makes sense to at least check for quality upgrades at least when the show is first imported (at least to me)

If you are importing shows, there is a good chance you’ve come from either manually downloading, or from Sickbeard/Sickrage. They have different indexers available, and it’s very likely you might find some different results from Sonarr indexers than you would have from another automation program. This is why in this case, I don’t think it’d simply be throwing a bunch of worthless API requests at indexers, as say a ‘search for every episode below cutoff for every show you already have imported’ button, as the comments seem to indicate (and I agree with, in that case.)

That is issue 1.

Here is issue 2. If even a single episode of a season meets cutoff, then season packs are rejected.

15-7-22 22:05:48.0|Debug|Parser|Parsing string ‘REMOVED S05 720p BluRay FLAC2 0 x264-EbP’
15-7-22 22:05:48.0|Debug|Parser|Episode Parsed. REMOVED - Season 05
15-7-22 22:05:48.0|Debug|Parser|Language parsed: English
15-7-22 22:05:48.0|Debug|NzbDrone.Core.Parser.QualityParser|Trying to parse quality for REMOVED S05 720p BluRay FLAC2 0 x264-EbP
15-7-22 22:05:48.0|Debug|Parser|Quality parsed: Bluray-720p v1
15-7-22 22:05:48.0|Debug|Parser|Release Group parsed: EbP
15-7-22 22:05:48.0|Debug|AcceptableSizeSpecification|Beginning size check for: REMOVED S05 720p BluRay FLAC2 0 x264-EbP
15-7-22 22:05:48.0|Debug|AcceptableSizeSpecification|Item: REMOVED S05 720p BluRay FLAC2 0 x264-EbP, meets size constraints.
15-7-22 22:05:48.0|Debug|CutoffSpecification|Comparing file quality with report. Existing file is HDTV-720p v1
15-7-22 22:05:48.0|Debug|CutoffSpecification|Comparing file quality with report. Existing file is Bluray-720p v1
15-7-22 22:05:48.0|Debug|QualityUpgradableSpecification|Existing item meets cut-off. skipping.
15-7-22 22:05:48.0|Debug|CutoffSpecification|Cutoff already met, rejecting.
15-7-22 22:05:48.0|Debug|LanguageSpecification|Checking if report meets language requirements. English
15-7-22 22:05:48.0|Debug|ReleaseRestrictionsSpecification|Checking if release meets restrictions: REMOVED S05 720p BluRay FLAC2 0 x264-EbP
15-7-22 22:05:48.0|Debug|ReleaseRestrictionsSpecification|[REMOVED S05 720p BluRay FLAC2 0 x264-EbP] No restrictions apply, allowing
15-7-22 22:05:48.0|Debug|QualityAllowedByProfileSpecification|Checking if report meets quality requirements. Bluray-720p v1
15-7-22 22:05:48.0|Debug|MinimumAgeSpecification|Not checking minimum age requirement for non-usenet report
15-7-22 22:05:48.0|Debug|RetentionSpecification|Not checking retention requirement for non-usenet report
15-7-22 22:05:48.0|Debug|DelaySpecification|Ignore delay for searches
15-7-22 22:05:48.0|Debug|HistorySpecification|Skipping history check during search
15-7-22 22:05:48.0|Debug|SeriesSpecification|Checking if series matches searched series
15-7-22 22:05:48.1|Debug|UpgradeDiskSpecification|Comparing file quality with report. Existing file is HDTV-720p v1
15-7-22 22:05:48.1|Debug|UpgradeDiskSpecification|Comparing file quality with report. Existing file is Bluray-720p v1
15-7-22 22:05:48.1|Debug|QualityUpgradableSpecification|existing item has better or equal quality. skipping
15-7-22 22:05:48.1|Debug|DownloadDecisionMaker|Release rejected for the following reasons: [Permanent] Existing file meets cutoff: Bluray-1080p, [Permanent] Quality for existing file on disk is of equal or higher preference: Bluray-720p v1

This log shows a part of the Season 5 search I just performed. In it you see that it checks to see that it indeed matches all other criteria, which it does. Then it checks episode 1. Episode 1 is HDTV-720p. It moves on to episode 2 which is is Bluray-720p. It checks episode 2, see that it meets the cutoff, and then rejects the entire season pack. It doesn’t bother looking at the other six episodes, all of which are below the cutoff.

In short, if you have even a single episode that meets cutoff, regardless of the status of the rest of the season missing or not, season packs are rejected.

Thanks for reading my long annoying posts, and being you, the wonderful dev you are. :smile:

Correct, it comes down to a season level, if the season was missing two or more episodes the full season is searched for, if none are missing (as is the case with season 5 of your show), nothing would happen. If you looked at ((debug logs)) for the season 3 searches you would see that it did a season search (not each episode).

In some cases (a lot?) it is a waste, it really depends on a number of factors, if there season just ended a search for upgrades probably wouldn’t result in anything (assuming the cutoff is Bluray and you have the top quality under Bluray already). This is very much a damned if you do, damned if you don’t scenario, if we don’t add support for searching (like we already have for missing) then people are upset (to some level) if we do add it we risk indexers getting mad at us because some user with a free account sent their server 10,000 requests (although we have some improvements coming for that issue).

I’ve added it to Github to let the other devs comment on it:

I definitely understand both sides of the coin in this case. Tough choice.

On a side note sorry for the torrent of threads from me in the last few days. I worked in Software QA for 5 years, mostly blackbox testing. Because of that I have a natural urge to poke at software with a stick. Sorry if I come across as ungrateful. Sonarr really is a great piece of software.

I’m also glad to help out where I can. I took a couple years of programming in school, but that was over 5 years ago, and frankly I suck at it. I might be of use though if you come out with new features that you want torture tested. I could easily create a test system and I’m pretty good with coming up with test cases and error reporting. Just let me know if you ever have a need.

Thanks for your patience.

Definitely not a bother or you coming across as being ungrateful, the team can only think of so much, a lot comes from users, so we appreciate the feedback and suggestions, even if have enough work for years to come already :smiley:

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.